This is my first PR here. Please tell me if there's anything I need to change to get this merged 😄

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 457144
Commit: ae8a6a5efda5343e2da14de0d25246c770ac8852

aarch64-darwin

Thanks for this fix. I'm slightly unhappy about the consequence that many older devices won't be able to run mpd any more, but that is precisely something that many people repurpose them for.

Can you check if this alternative workaround also fixes the build:

diff --git i/pkgs/by-name/mp/mpd/package.nix w/pkgs/by-name/mp/mpd/package.nix
index 3bcc8851ae0a..14f600a77a12 100644
--- i/pkgs/by-name/mp/mpd/package.nix
+++ w/pkgs/by-name/mp/mpd/package.nix
@@ -234,7 +234,13 @@ stdenv.mkDerivation (finalAttrs: {
         substituteInPlace src/output/plugins/OSXOutputPlugin.cxx \
           --replace kAudioObjectPropertyElement{Main,Master} \
           --replace kAudioHardwareServiceDeviceProperty_Virtual{Main,Master}Volume
-      '';
+      ''
+    +
+      lib.optionalString
+        (stdenv.hostPlatform.isDarwin && lib.versionOlder stdenv.hostPlatform.darwinSdkVersion "13.3")
+        ''
+          sed -i "/subdir('time')/d" test/meson.build
+        '';

   # Otherwise, the meson log says:
   #

In case it won't I will approve your change to set the deployment target.

Ran into this same error on a couple of my out-of-tree packages. I managed to track it down to the libc++ change in #398727: The Apple libc++ implements std::format on top of to_chars, which only exists in the newer versions of macOS.

In this case, mpd itself is using fmt rather than the native std::format, so it shouldn't be running into this… but that one test subdirectory is using gtest, which is using std::format.

@tobim I checked your patch and it also worked. I've updated the branch.

@tobim I checked your patch and it also worked. I've updated the branch.

Great, thanks! Please you drop the original commit instead of adding a revert and change the title of the final commit to something like:

mpd: fix build on darwin

Ok. Done 😄

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2625